refactor(rust): simplify FFI array operations using view helpers#8
Merged
CodeWithKyrian merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
Refactor FFI array operations to use standardized view extraction helpers instead of wrapper methods. Removes redundant macros and simplifies the wrapper module by inlining operation logic directly in FFI functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the copy, fill, and assign FFI operations to use standardized view extraction helpers, eliminating redundant wrapper methods and macros.
Motivation and Context
The wrapper module contained multiple macro-generated methods (
copy_view_*,fill_slice_,assign_slice_) that duplicated view extraction logic. By moving this logic directly into the FFI functions and using standardized view helpers, we create a cleaner separation of concerns where the wrapper only contains essential functionality while the FFI layer handles operation-specific logic.What's Changed
ffi/array/copy.rsto useextract_view_*helpersffi/indexing/fill.rsto useextract_view_mut_*helpersffi/indexing/assign.rsto inline all assignment logicdefine_extract_view_mutmacro for mutable view extractionhelpers/view.rsimpl_copy_view,impl_fill_sliceandimpl_assign_slicemacrosto_owned()only for same-array caseBreaking Changes
None. All changes are internal to the Rust crate. The FFI interface and PHP API remain unchanged.